Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

From	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?
Date	2016-06-28 12:00 +0200
Message-ID	<rOXYd-5cW-3@gated-at.bofh.it> (permalink)
References	<rOzMe-62T-23@gated-at.bofh.it> <rOSvv-1Jz-1@gated-at.bofh.it> <rOVjI-3E5-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote:
> 
> I don't know the code, but given that insn is unsigned long and so
> can go
> past 32 bits, using a cast to unsigned int might throw away the
> possibly important
> upper bits.

our instructions are only ever 32-bits. That xmon code is ancient and
originated from 32-bits stuff. In fact some of Paulus earliest xmons
might even have run on platforms where int is 16 bits :-)

Cheers,
Ben.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-27 10:10 +0200
  Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? Michael Ellerman <mpe@ellerman.id.au> - 2016-06-28 06:10 +0200
    Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-28 09:10 +0200
      Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? Michael Ellerman <mpe@ellerman.id.au> - 2016-06-28 09:20 +0200
      Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? Segher Boessenkool <segher@kernel.crashing.org> - 2016-06-28 11:00 +0200
      Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-06-28 12:00 +0200

csiph-web