Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets
Date	2016-06-28 11:40 +0200
Message-ID	<rOXES-54O-9@gated-at.bofh.it> (permalink)
References	<rNuvf-5Ca-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Dexuan Cui <decui@microsoft.com>
Date: Fri, 24 Jun 2016 07:45:24 +0000

> +	while ((ret = vmalloc(size)) == NULL)
> +		ssleep(1);

This is completely, and entirely, unacceptable.

If the allocation fails, you return an error and release
your resources.

You don't just loop forever waiting for it to succeed.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets David Miller <davem@davemloft.net> - 2016-06-28 11:40 +0200
  RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui <decui@microsoft.com> - 2016-06-28 13:00 +0200
    Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets David Miller <davem@davemloft.net> - 2016-06-28 15:50 +0200
      RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui <decui@microsoft.com> - 2016-06-28 17:40 +0200
    Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets Rick Jones <rick.jones2@hpe.com> - 2016-06-28 17:50 +0200
      RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets Dexuan Cui <decui@microsoft.com> - 2016-06-29 11:20 +0200

csiph-web