Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432515

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().
Date 2016-06-28 08:30 +0200
Message-ID <rOUGZ-39l-15@gated-at.bofh.it> (permalink)
References <rOThT-25m-1@gated-at.bofh.it> <rOTBf-2tn-19@gated-at.bofh.it> <rOUnD-328-9@gated-at.bofh.it> <rOUGZ-39l-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-06-28 at 08:22 +0200, Eric Dumazet wrote:

> Follow the stack trace and add another cond_resched() where it is needed
> then ?
> 
> Lot of this code was written decade ago where nobody expected a root
> user was going to try hard to crash its host ;)
> 
> I did not check if the following is valid (Maybe __fib6_clean_all() is
> called with some spinlock/rwlock held)

Well, fib6_run_gc() can call it with
spin_lock_bh(&net->ipv6.fib6_gc_lock) so this wont work.

We need more invasive changes.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Ding Tianhong <dingtianhong@huawei.com> - 2016-06-28 07:00 +0200
  Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Eric Dumazet <eric.dumazet@gmail.com> - 2016-06-28 07:20 +0200
    Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Ding Tianhong <dingtianhong@huawei.com> - 2016-06-28 08:10 +0200
      Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Eric Dumazet <eric.dumazet@gmail.com> - 2016-06-28 08:30 +0200
        Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Eric Dumazet <eric.dumazet@gmail.com> - 2016-06-28 08:30 +0200
          Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Ding Tianhong <dingtianhong@huawei.com> - 2016-07-01 05:10 +0200
            Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Eric Dumazet <eric.dumazet@gmail.com> - 2016-07-01 07:20 +0200
        Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain(). Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-28 19:40 +0200

csiph-web