Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain().

From	Ding Tianhong <dingtianhong@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain().
Date	2016-06-28 05:40 +0200
Message-ID	<rOS2t-1ib-7@gated-at.bofh.it> (permalink)
References	<rNLPr-8d9-1@gated-at.bofh.it> <rOKRj-4Jx-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/6/28 3:50, Cong Wang wrote:
> On Fri, Jun 24, 2016 at 7:46 PM, Ding Tianhong <dingtianhong@huawei.com> wrote:
>> diff --git a/kernel/notifier.c b/kernel/notifier.c
>> index fd2c9ac..9c30411 100644
>> --- a/kernel/notifier.c
>> +++ b/kernel/notifier.c
>> @@ -92,6 +92,8 @@ static int notifier_call_chain(struct notifier_block **nl,
>>  #endif
>>                 ret = nb->notifier_call(nb, val, v);
>>
>> +               cond_resched();
>> +
>>                 if (nr_calls)
>>                         (*nr_calls)++;
> 
> NAK.
> 
> You can't do a resched in atomic context in __atomic_notifier_call_chain().
> 
> 
Sorry, I miss this, so I think add touch_nmi_watchdog looks like the best solution for this problem.

Thanks
Ding

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] notifier: Fix soft lockup for notifier_call_chain(). Ding Tianhong <dingtianhong@huawei.com> - 2016-06-25 04:50 +0200
  Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain(). Cong Wang <xiyou.wangcong@gmail.com> - 2016-06-27 22:00 +0200
    Re: [PATCH] notifier: Fix soft lockup for notifier_call_chain(). Ding Tianhong <dingtianhong@huawei.com> - 2016-06-28 05:40 +0200

csiph-web