Re: [PATCH] geneve: fix max_mtu setting

From	Jesse Gross <jesse@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] geneve: fix max_mtu setting
Date	2016-06-28 05:00 +0200
Message-ID	<rORpL-Mx-1@gated-at.bofh.it> (permalink)
References	<rO9RQ-6w9-3@gated-at.bofh.it> <rOtns-1Tq-7@gated-at.bofh.it> <rOtns-1Tq-5@gated-at.bofh.it> <rOHqp-2AK-9@gated-at.bofh.it> <rORpL-Mx-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 27, 2016 at 6:27 PM, 严海双 <yanhaishuang@cmss.chinamobile.com> wrote:
>
> On Jun 28, 2016, at 12:10 AM, Jesse Gross <jesse@kernel.org> wrote:
>
> On Sun, Jun 26, 2016 at 6:13 PM, Haishuang Yan
> <yanhaishuang@cmss.chinamobile.com> wrote:
>
>
> On Jun 26, 2016, at 8:35 PM, zhuyj <zyjzyj2000@gmail.com> wrote:
>
> +       if (geneve->remote.sa.sa_family == AF_INET)
> +               max_mtu -= sizeof(struct iphdr);
> +       else
> +               max_mtu -= sizeof(struct ipv6hdr);
>
> Sorry, if sa_family is not AF_NET, it is AF_INET6?
>
> There is a lot of macros in include/linux/socket.h.
>
> Zhu Yanjun
>
>
> There are only two enumerations AF_INET and AF_INET6 have been assigned in
> geneve_newlink:
>
>
> There's actually a third possibility: AF_UNSPEC, which is the default
> if neither remote type is specified. This is used by lightweight
> tunnels and should be able to work with either IPv4/v6. For the
> purposes of the MTU calculation this means that the IPv4 header size
> should be used to avoid disallowing potentially valid configurations.
>
>
> Yes, you’re right. Thanks for you advise. I will send a v2 commit like this:
>
>        if (geneve->remote.sa.sa_family == AF_INET6)
>               max_mtu -= sizeof(struct ipv6hdr);
>        else
>               max_mtu -= sizeof(struct iphdr);
>
> Is this ok?

Yes, that looks fine to me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] geneve: fix max_mtu setting Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2016-06-26 06:30 +0200
  Re: [PATCH] geneve: fix max_mtu setting 严海双 <yanhaishuang@cmss.chinamobile.com> - 2016-06-27 03:20 +0200
    Re: [PATCH] geneve: fix max_mtu setting Jesse Gross <jesse@kernel.org> - 2016-06-27 18:20 +0200
      Re: [PATCH] geneve: fix max_mtu setting Jesse Gross <jesse@kernel.org> - 2016-06-28 05:00 +0200

csiph-web