Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432346
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andy Lutomirski <luto@amacapital.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" |
| Date | Tue, 28 Jun 2016 00:30:01 +0200 |
| Message-ID | <rONct-6pd-3@gated-at.bofh.it> (permalink) |
| References | <rN8l4-7kx-19@gated-at.bofh.it> <rOIZb-3tG-5@gated-at.bofh.it> |
| X-Original-To | Andy Lutomirski <luto@kernel.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iIysvzhjtoMkdTQZpmRyB7a5w1ZI3vJ5KtE46SahUcg=; b=FBkRwzVk7jzUbphd/1XxResJzhvXvX9+UgOoNk/dQC4mLQbWP0aqo8/QvQZ08HxvTq 6OXc2ithcA8KJGiFl0+eD4HCBhCyovad06apEvIR8VaHHfUzBDIwXRJQa2A76Dy0jmCs cIWtyXUVAAP6gMKjPAb3hQRsSzcZcMGn4eEhFqMMLyVtJeoX3NvpEscJaqsU9w8KEK7+ a4SaR9cfMQMtj3CY8ITMN5t3lxoRGlmR69o1URgnMRK/KcFVKv2YJrf2pJ7t9I2K93Wg hg2G8wErnDikSzK0QwgcMp4JIgG4A8fp5tjnHuE9LTuefAQAKNxAR4dHqwZI+J4dBGp9 s+7w== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iIysvzhjtoMkdTQZpmRyB7a5w1ZI3vJ5KtE46SahUcg=; b=eFJAoVwqPDPXpqxyaQLi2dD1W3MhT3wvaoVunzNmihHLR7nKezN2ozQYz4HiavsyHF DdhR1DGCbnTPR8dGEs4KcHX6zuD04HUMfCuTrMvFcaT9q0qtSuOMYQKU1nIh+SUP30li TD6uICnvLvcMUsJ/CEFrVexx82yjAT54wqv9yD+gXTxaOmPKNluPXhEmgk0lq8jNUqH3 5hdjn1opday92wqZhLrthGvtthkqOkGxvLoubHcV3XXgnoyuHYXHJzBMcnIay/cQBLtd 385gyoQ1jjXS0m4CQ66bzpK+2KVsSEGcA6vltM2xhcXiIkfIn7+dSUbdNl/CiJSQn2VA uimw== |
| X-Gm-Message-State | ALyK8tKBcqHk/hKTLTj4t11j5TiPlLfVFT9QtivIKFhmf+ebh4cRMjvCX0XwAX1sThF/nZ/k1CDQlLRivYlVn8eV |
| X-Received | by 10.176.7.7 with SMTP id h7mr9746313uah.9.1467066361177; Mon, 27 Jun 2016 15:26:01 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 53 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Allen Hung <allen_hung@dell.com>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> |
| X-Original-Date | Mon, 27 Jun 2016 15:25:41 -0700 |
| X-Original-Message-ID | <CALCETrWhHWeqGK6zmng=+8_N87cezi6EwO7xW96HoMTxTkzxeQ@mail.gmail.com> |
| X-Original-References | <1466670690-77458-1-git-send-email-allen_hung@dell.com> <2407f04d-4658-c3d5-1434-5e548f2063e0@kernel.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1432346 |
Show key headers only | View raw
On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote:
> On 06/23/2016 01:31 AM, Allen Hung wrote:
>>
>> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
>> if device implements confidence usage")
>>
>> The commit enables palm rejection for Win8 Precision Touchpad devices but
>> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
>> properly. This quirk is originally designed for some WIn7 touchscreens.
>> Use
>> of this for a Win8 Precision Touchpad will cause unexpected pointer
>> jumping
>> problem.
>>
>> Signed-off-by: Allen Hung <allen_hung@dell.com>
>> ---
>> drivers/hid/hid-multitouch.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 95b7d61..4ef7006 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device
>> *hdev, struct hid_input *hi,
>> mt_store_field(usage, td, hi);
>> return 1;
>> case HID_DG_CONFIDENCE:
>> - if (cls->name == MT_CLS_WIN_8 &&
>> - field->application == HID_DG_TOUCHPAD) {
>> - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
>> - cls->quirks |=
>> MT_QUIRK_VALID_IS_CONFIDENCE;
>> - }
>> mt_store_field(usage, td, hi);
>> return 1;
>> case HID_DG_TIPSWITCH:
>>
>
> This and patch 2 are:
>
> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
>
> (And I'm curious why 1.4.3 seems to have been pulled. Might it have been
> this issue? For better or for worse, I upgraded in the narrow window in
> which it was available on Dell's website.)
>
I should amend that Tested-by slightly: these patches seem to make the
problem merely about as bad as it was before. It's still not perfect
-- I still occasionally get stuck touches.
--Andy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Andy Lutomirski <luto@kernel.org> - 2016-06-27 20:00 +0200
Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 00:30 +0200
Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 19:50 +0200
Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-28 13:30 +0200
csiph-web