Re: [PATCH] x86: prevent gcc from emitting SSE into boot code

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: prevent gcc from emitting SSE into boot code
Date	2016-06-27 21:10 +0200
Message-ID	<rOJVg-454-19@gated-at.bofh.it> (permalink)
References	<rMUi5-6sA-7@gated-at.bofh.it> <rMWMW-87F-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Wed, Jun 22, 2016 at 7:37 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> > Latest gcc manages to emit MOVDQA into boot code
> > which leads to crashes. Add more -mno-see flags.

Which GCC version is that?

> >
> > Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> > ---
> >  arch/x86/boot/compressed/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> > index f135688..7eaafb8 100644
> > --- a/arch/x86/boot/compressed/Makefile
> > +++ b/arch/x86/boot/compressed/Makefile
> > @@ -31,7 +31,7 @@ KBUILD_CFLAGS += -DDISABLE_BRANCH_PROFILING
> >  cflags-$(CONFIG_X86_32) := -march=i386
> >  cflags-$(CONFIG_X86_64) := -mcmodel=small
> >  KBUILD_CFLAGS += $(cflags-y)
> > -KBUILD_CFLAGS += -mno-mmx -mno-sse
> > +KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-sse2 -mno-sse3
> >  KBUILD_CFLAGS += $(call cc-option,-ffreestanding)
> >  KBUILD_CFLAGS += $(call cc-option,-fno-stack-protector)
> >
> > --
> > 2.8.0.rc3.226.g39d4020
> 
> 
> I withdraw this patch.
> 
> From off-list discussion:
> 
> "-mno-sse alone should disable all SSE/AVX instructions. If not,
> please file a GCC bug report".

So the GCC documentation says:

 -mmmx
 -mno-mmx
 -msse
 -mno-sse
 -msse2
 -mno-sse2
 -msse3
 -mno-sse3
 -m3dnow
 -mno-3dnow
    These switches enable or disable the use of built-in functions that allow 
    direct access to the MMX, SSE, SSE2, SSE3 and 3Dnow extensions of the 
    instruction set.

Technically -mno-mmx won't turn off SSE instructions because they are independent. 
Do we really want to rely on an undocumented property of -mno-sse (clearly broken 
in at least one released GCC version), especially as the fix is so easy?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86: prevent gcc from emitting SSE into boot code Ingo Molnar <mingo@kernel.org> - 2016-06-27 21:10 +0200

csiph-web