Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1432129

Re: [PATCH] [perf]: update makefile message for installing required libs

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] [perf]: update makefile message for installing required libs
Date 2016-06-27 17:40 +0200
Message-ID <rOGNH-27J-5@gated-at.bofh.it> (permalink)
References <rOFoC-1gZ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@gmail.com escreveu:
> From: Neeraj Badlani <neerajbadlani@gmail.com>
> 
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
> 
> Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>  
>  ifndef NO_SLANG
>    ifneq ($(feature-libslang), 1)
> -    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> +    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);

Too many 'or', I'll apply it as:

+    msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);

Thanks,

- Arnaldo

>      NO_SLANG := 1
>    else
>      # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> -- 
> 2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] [perf]: update makefile message for installing required libs neerajbadlani@gmail.com - 2016-06-27 16:10 +0200
  Re: [PATCH] [perf]: update makefile message for installing required  libs Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-27 17:40 +0200
  [tip:perf/core] perf tools: Update makefile message for installing  slang devel package tip-bot for Neeraj Badlani <tipbot@zytor.com> - 2016-06-29 11:50 +0200

csiph-web