Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432092

Re: [PATCH] dsa: mv88e6xxx: hide unused functions

Show all headers | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Thu, 23 Jun 2016 11:21:27 -0400

> Hi,
> 
> Arnd Bergmann <arnd@arndb.de> writes:
> 
>> When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused
>> functions whose only callers are all inside of an #ifdef:
>>
>> drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function]
>> drivers/net/dsa/mv88e6xxx.c:3244:12: 'mv88e6xxx_mdio_page_read' defined but not used [-Werror=unused-function]
>>
>> This adds another ifdef around the function definitions. The warnings
>> appeared after the functions were marked 'static', but the problem
>> was already there before that.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 57d3231057e9 ("net: dsa: mv88e6xxx: fix style issues")
> 
> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> David, this patch is meant for net-next. It applies cleanly *before* my
> last two submissions:
> 
>     1/2 http://patchwork.ozlabs.org/patch/638773/
>     2/2 http://patchwork.ozlabs.org/patch/638772/

Oops, I applied those already.

Arnd, please respin if necessary.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] dsa: mv88e6xxx: hide unused functions David Miller <davem@davemloft.net> - 2016-06-27 16:50 +0200

csiph-web