Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1432009

Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models

Show all headers | View raw

> > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad
> > toggle hotkey (Fn+F4) which is handled transparently to the operating
> > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is
> > pressed, touchpad state is properly toggled without any explicit support
> > for this operation in fujitsu-laptop.
> > :
> 
> I am happy with the patch code once the one-line fix from Jan-Marek is
> included.  However, given the rather non-intuitive behaviour that the patch
> is dealing with I wonder whether a short (2 line) comment in the code might
> be justified.  There is otherwise no obvious reason why the touchpad button
> code must interact with the rf kill hardware.
> 
> Please respin the patch with the above in mind (and inlude Jan-Marek's fix).

Will do, thanks for the review.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień <kernel@kempniu.pl> - 2016-06-26 09:50 +0200
  [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski <glogow@fbihome.de> - 2016-06-27 10:10 +0200
  Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on  Skylake-based models Michał Kępień <kernel@kempniu.pl> - 2016-06-27 15:00 +0200
  Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on  Skylake-based models Jonathan Woithe <jwoithe@just42.net> - 2016-06-27 15:00 +0200
    [PATCH v2] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień <kernel@kempniu.pl> - 2016-06-27 15:30 +0200
      Re: [PATCH v2] fujitsu-laptop: Support touchpad toggle hotkey on  Skylake-based models Jonathan Woithe <jwoithe@just42.net> - 2016-06-28 03:10 +0200
        [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień <kernel@kempniu.pl> - 2016-06-28 09:30 +0200
          Re: [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on  Skylake-based models Jonathan Woithe <jwoithe@just42.net> - 2016-06-28 13:30 +0200
            Re: [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on  Skylake-based models Darren Hart <dvhart@infradead.org> - 2016-06-28 20:00 +0200

csiph-web