Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431856
| From | Heikki Krogerus <heikki.krogerus@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region |
| Date | 2016-06-27 11:30 +0200 |
| Message-ID | <rOB1D-6Kn-13@gated-at.bofh.it> (permalink) |
| References | <rNntL-Yr-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Whoa! Hold on!
On Thu, Jun 23, 2016 at 05:52:53PM -0700, Bin Gao wrote:
> Broxton platform firmware has defined new customized operation regions
> called regs for PMIC chip - regs op region is used to handle the
> PMIC gpio mainly intended for the TYPE-C VBUS and Orientation.
>
> The intel_gpio_ctx structure is created for the purpose of handling
> the PMIC gpio register read and write.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> Signed-off-by: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>
> Signed-off-by: Bin Gao <bin.gao@intel.com>
> ---
> Changes in v4:
> - various fixes to address Aaron's comments.
> Changes in v3: none
> Changes in v2: none
> drivers/acpi/pmic/intel_pmic.c | 74 ++++++++++++++++++++++++++++++++++++++++--
> drivers/acpi/pmic/intel_pmic.h | 5 +++
> 2 files changed, 76 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/pmic/intel_pmic.c b/drivers/acpi/pmic/intel_pmic.c
> index 410e96f..e11d1e0 100644
> --- a/drivers/acpi/pmic/intel_pmic.c
> +++ b/drivers/acpi/pmic/intel_pmic.c
> @@ -21,12 +21,14 @@
>
> #define PMIC_POWER_OPREGION_ID 0x8d
> #define PMIC_THERMAL_OPREGION_ID 0x8c
> +#define PMIC_REGS_OPREGION_ID 0x8f
>
> struct intel_pmic_opregion {
> struct mutex lock;
> struct acpi_lpat_conversion_table *lpat_table;
> struct regmap *regmap;
> struct intel_pmic_opregion_data *data;
> + struct pmic_gpio_ctx ctx;
What gpio?
> };
>
> static int pmic_get_reg_bit(int address, struct pmic_table *table,
> @@ -204,6 +206,56 @@ static acpi_status intel_pmic_thermal_handler(u32 function,
> return AE_OK;
> }
>
> +static acpi_status intel_pmic_gpio_handler(u32 function,
> + acpi_physical_address address, u32 bits, u64 *value64,
> + void *handler_context, void *region_context)
What the heck is this? Why is this suddenly a gpio handler?
This is handler for an operation region, not some gpio!
--
heikki
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region Bin Gao <bin.gao@linux.intel.com> - 2016-06-24 02:50 +0200
Re: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-06-27 11:30 +0200
Re: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-27 15:30 +0200
Re: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-06-27 16:40 +0200
Re: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-27 22:30 +0200
RE: [PATCH v4 3/3] acpi/pmic: Add support for PMIC regs operation region "Gao, Bin" <bin.gao@intel.com> - 2016-06-27 23:30 +0200
csiph-web