Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431256

Re: [PATCH] orangefs: fix namespace handling

Show all headers | View raw

Your suggestions make sense to me, especially after looking
at how other filesystems use init_user_ns...

As far as kicking us out of the Kernel, good grief, I hope not, it
was hard getting into the kernel!

-Mike

On Sat, Jun 25, 2016 at 12:29 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
> Jann Horn <jannh@google.com> writes:
>
>> diff --git a/fs/orangefs/devorangefs-req.c b/fs/orangefs/devorangefs-req.c
>> index db170be..a287a66 100644
>> --- a/fs/orangefs/devorangefs-req.c
>> +++ b/fs/orangefs/devorangefs-req.c
>> @@ -116,6 +116,13 @@ static int orangefs_devreq_open(struct inode *inode, struct file *file)
>>  {
>>       int ret = -EINVAL;
>>
>> +     /* in order to ensure that the filesystem driver sees correct UIDs */
>> +     if (file->f_cred->user_ns != &init_user_ns) {
>> +             gossip_err("%s: device cannot be opened outside init_user_ns\n",
>> +                        __func__);
>> +             goto out;
>> +     }
>> +
>
> Not necessarily in this patch but the code should also verify that the
> opener is also in the initial pid namespace as pids are transferred in
> the upcalls as well.
>
>>       if (!(file->f_flags & O_NONBLOCK)) {
>>               gossip_err("%s: device cannot be opened in blocking mode\n",
>>                          __func__);
>
> Eric

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] orangefs: fix namespace handling Jann Horn <jannh@google.com> - 2016-06-25 02:00 +0200
  Re: [PATCH] orangefs: fix namespace handling ebiederm@xmission.com (Eric W. Biederman) - 2016-06-25 06:50 +0200
    Re: [PATCH] orangefs: fix namespace handling Mike Marshall <hubcap@omnibond.com> - 2016-06-26 01:10 +0200

csiph-web