Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1430464

[PATCH v2 3/5] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3

From Keerthy <j-keerthy@ti.com>
Newsgroups linux.kernel
Subject [PATCH v2 3/5] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3
Date 2016-06-24 10:40 +0200
Message-ID <rNuOB-5IF-19@gated-at.bofh.it> (permalink)
References <rNuEV-5Fl-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Tero Kristo <t-kristo@ti.com>

The reset value for this register seems broken on certain versions of
tps65218 chip, so make sure the dcdc3 settings is proper. Needed for
proper functionality of rtc+ddr / rtc-only modes.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/regulator/tps65218-regulator.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 8eca1eb..d1e631d 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -180,8 +180,12 @@ static int tps65218_pmic_set_suspend_disable(struct regulator_dev *dev)
 	if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
 		return -EINVAL;
 
-	if (!tps->info[rid]->strobe)
-		return -EINVAL;
+	if (!tps->info[rid]->strobe) {
+		if (rid == TPS65218_DCDC_3)
+			tps->info[rid]->strobe = 3;
+		else
+			return -EINVAL;
+	}
 
 	return tps65218_set_bits(tps, dev->desc->bypass_reg,
 				 dev->desc->bypass_mask,
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/5] regulator: tps65217: Enable suspend configuration Keerthy <j-keerthy@ti.com> - 2016-06-24 10:30 +0200
  [PATCH v2 3/5] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy <j-keerthy@ti.com> - 2016-06-24 10:40 +0200
  [PATCH v2 2/5] regulator: tps65218: Enable suspend configuration Keerthy <j-keerthy@ti.com> - 2016-06-24 10:40 +0200
  Applied "regulator: tps65217: Enable suspend configuration" to the regulator tree Mark Brown <broonie@kernel.org> - 2016-06-27 19:10 +0200

csiph-web