Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430328

Re: [PATCH] arm64:swiotlb:Enable only when Input size through command line

Show all headers | View raw

Dear Konrad,

On Thu, 23 Jun 2016 12:06:10 -0400 Konrad Rzeszutek Wilk wrote:

> On June 23, 2016 10:30:34 AM EDT, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >On Thu, Jun 23, 2016 at 05:43:40PM +0530, Manjeet Pawar wrote:  
> >> From: Rohit Thapliyal <r.thapliyal@samsung.com>
> >> 
> >> swiotlb default size of 64M is too big as
> >> default value therefore it is made configurable
> >> through command line through swiotlb_size parameter.
> >> swiotlb allocation shall be done only when the
> >> swiotlb size is given through command line.
> >> Otherwise no swiotlb is allocated.  
> >
> >I already queued this patch:
> >
> >http://lkml.kernel.org/g/1465372426-4077-1-git-send-email-jszhang@marvell.com
> >
> >If you have any objections to it, please reply there.  
> 
> 
> I do (sorry about duplicate email, the other got rejected by mailing lists).
> 
> Why not expand the swiotlb= parameter instead of introducing a new one?

Do you mean pass "swiotlb=" for those platforms(most probably, arm64 with less
than 4GB DDR) which don't need swiotlb? I'm afraid this is not convenient, and
users even don't notice swiotlb parameter. From another side, pass "swiotlb=0"
will make the swiotlb reserve 64MB instead, so how can we achieve zero reserved
memory for swiotlb through "swiotlb=" parameter?

PS: my patch didn't introduce new boot parameter.

I'm not sure I got your meaning, so could you please comment my patch
directly?

Thanks,
Jisheng

> 
> Also, why not use the swiotlb by itself? That does the job as well?
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64:swiotlb:Enable only when Input size through command line Manjeet Pawar <manjeet.p@samsung.com> - 2016-06-23 14:20 +0200
  Re: [PATCH] arm64:swiotlb:Enable only when Input size through command  line Robin Murphy <robin.murphy@arm.com> - 2016-06-23 14:40 +0200
  Re: [PATCH] arm64:swiotlb:Enable only when Input size through  command line Catalin Marinas <catalin.marinas@arm.com> - 2016-06-23 16:40 +0200
    Re: [PATCH] arm64:swiotlb:Enable only when Input size through command line Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-06-23 18:10 +0200
      Re: [PATCH] arm64:swiotlb:Enable only when Input size through  command line Jisheng Zhang <jszhang@marvell.com> - 2016-06-24 05:10 +0200
        Re: [PATCH] arm64:swiotlb:Enable only when Input size through  command line Konrad Rzeszutek Wilk <konrad@darnok.org> - 2016-06-24 12:50 +0200
          Re: [PATCH] arm64:swiotlb:Enable only when Input size through command  line Robin Murphy <robin.murphy@arm.com> - 2016-06-24 13:00 +0200

csiph-web