Re: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width

From	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Newsgroups	linux.kernel
Subject	Re: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width
Date	2016-06-23 23:20 +0200
Message-ID	<rNkcy-7lw-23@gated-at.bofh.it> (permalink)
References	<rMKsp-iq-13@gated-at.bofh.it> <rN6CB-6aT-5@gated-at.bofh.it>
Organization	Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk

Show all headers | View raw

On 6/23/2016 8:45 AM, Mike Galbraith wrote:
> Commit 920de6ebfab8 apparently exposed a latent bug, doorbell.access_width
> is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making
> that change does bring pcc-cpufreq back to life.
>
> Suggested-by: Lv Zheng <lv.zheng@intel.com>
> Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
> ---
>   drivers/cpufreq/pcc-cpufreq.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void
>   	doorbell.space_id = reg_resource->space_id;
>   	doorbell.bit_width = reg_resource->bit_width;
>   	doorbell.bit_offset = reg_resource->bit_offset;
> -	doorbell.access_width = 64;
> +	doorbell.access_width = 4;
>   	doorbell.address = reg_resource->address;
>   
>   	pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "


OK, I picked this up from the LKML patchwork (will push to Linus 
tomorrow), but next time please CC patches related to ACPI to linux-acpi 
and PM patches to linux-pm (so this one should have gone to both, 
ideally).  They are much easier to handle/review then and more people 
are likely to look at them too.


Thanks,

Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

4.7 regression - ACPICA: Hardware: Enhance  acpi_hw_validate_register() with access_width/bit_offset awareness Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-22 09:10 +0200
  RE: 4.7 regression - ACPICA: Hardware: Enhance  acpi_hw_validate_register() with access_width/bit_offset awareness "Zheng, Lv" <lv.zheng@intel.com> - 2016-06-23 02:40 +0200
    Re: 4.7 regression - ACPICA: Hardware: Enhance  acpi_hw_validate_register() with access_width/bit_offset awareness Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-23 06:40 +0200
  [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-23 08:50 +0200
    Re: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2016-06-23 23:20 +0200

csiph-web