Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1430004
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 |
| Date | 2016-06-23 19:30 +0200 |
| Message-ID | <rNgBX-4Mw-3@gated-at.bofh.it> (permalink) |
| References | <rNcoG-1GG-7@gated-at.bofh.it> <rNcoG-1GG-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Chris,
[ ... ]
> + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB,
> + &tcphy->event_nb);
> + if (ret) {
> + dev_err(dev, "regitster EXTCON_USB notifer failed\n");
> + return ret;
> + }
> +
> + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB_HOST,
> + &tcphy->event_nb);
> + if (ret) {
> + dev_err(dev, "regitster EXTCON_USB_HOST notifer failed\n");
> + return ret;
> + }
> +
> + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_DISP_DP,
> + &tcphy->event_nb);
> + if (ret) {
> + dev_err(dev, "regitster EXTCON_DISP_DP notifer failed\n");
> + return ret;
> + }
> +
I don't think you can register multiple notifiers with the same
notifier block. It may work by chance, but at least the 'next' object
in notifier_clock is set in notifier_chain_register(). Best case it
may work, but worst case it might cause a loop in the list of
notifiers.
Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[v3 PATCH 0/5] Rockchip Type-C and DispplayPort driver Chris Zhong <zyw@rock-chips.com> - 2016-06-23 15:00 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Kishon Vijay Abraham I <kishon@ti.com> - 2016-06-23 15:00 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-06-24 21:40 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong <zyw@rock-chips.com> - 2016-06-27 04:20 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Guenter Roeck <groeck@google.com> - 2016-06-27 06:10 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong <zyw@rock-chips.com> - 2016-06-27 06:50 +0200
[v3 PATCH 2/5] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY Chris Zhong <zyw@rock-chips.com> - 2016-06-23 15:00 +0200
Re: [v3 PATCH 2/5] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY Rob Herring <robh@kernel.org> - 2016-06-24 21:30 +0200
[v3 PATCH 4/5] Documentation: bindings: add dt documentation for cdn DP controller Chris Zhong <zyw@rock-chips.com> - 2016-06-23 15:00 +0200
Re: [v3 PATCH 4/5] Documentation: bindings: add dt documentation for cdn DP controller Rob Herring <robh@kernel.org> - 2016-06-24 21:30 +0200
[v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong <zyw@rock-chips.com> - 2016-06-23 15:00 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Guenter Roeck <groeck@google.com> - 2016-06-23 19:30 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Guenter Roeck <groeck@google.com> - 2016-06-23 23:50 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong <zyw@rock-chips.com> - 2016-06-24 02:40 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Guenter Roeck <groeck@google.com> - 2016-06-24 04:20 +0200
Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 Chris Zhong <zyw@rock-chips.com> - 2016-06-24 04:50 +0200
csiph-web