Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()
Date	2016-06-23 13:30 +0200
Message-ID	<rNaZz-OU-5@gated-at.bofh.it> (permalink)
References	<rMPBM-3lU-5@gated-at.bofh.it> <rN1MC-2UJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23/06/16 02:29, Julian Calaby wrote:
> Hi All,
> 
> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
> <luisbg@osg.samsung.com> wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>
>> Also, if there was an error returning -EINVAL instead of -1 is more
>> appropriate.
> 
> These two changes could be argued to be separate changes deserving of
> their own patches.
> 
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> 
> However if everyone else is ok with that, this is:
> 
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> 
> Thanks,
> 

Hi Julian,

If you don't mind I will resend as two separate patches and include your
Reviewed-by in both.

Thanks for the review,
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-22 14:40 +0200
  Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Julian Calaby <julian.calaby@gmail.com> - 2016-06-23 03:40 +0200
    Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Julian Calaby <julian.calaby@gmail.com> - 2016-06-23 13:30 +0200
    Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init() Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-23 13:30 +0200

csiph-web