Re: linux-next: manual merge of the audit tree with the security tree

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: linux-next: manual merge of the audit tree with the security tree
Date	2016-06-25 09:30 +0200
Message-ID	<rNQcp-2yr-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <rNfwe-45d-7@gated-at.bofh.it> <rNsa5-45P-3@gated-at.bofh.it> <rNAU1-1d8-15@gated-at.bofh.it> <rNBdn-1jE-1@gated-at.bofh.it> <rNC9s-1Zd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 24, 2016 at 12:20:52PM -0400, Paul Moore wrote:
> > I'm a bit concerned about user space pointers passed as argument for compat
> > tasks. These need to mask out 33 instead of 32 bits.  This is of course
> > system call specific and I don't know enough about audit to tell if it
> > could be a problem.
> 
> From a practical point of view I'm not sure how much of an impact that
> will have as it is unlikely anyone will be doing anything useful with
> those pointer values; for example, you aren't going to be inspecting a
> process' memory space using just the audit log.  Also, at the very
> least we aren't removing any information, just adding in an extra bit
> of potential junk.  Anyone who does care about user space pointers in
> the audit log, should have all the information the need to drop the
> high bit.
> 
> Does that sound reasonable?

Yes, it does. If there should be problems because of the one extra bit that
potentially contains garbage we still can look for a way to fix this.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: linux-next: manual merge of the audit tree with the security tree Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-06-24 07:50 +0200
  Re: linux-next: manual merge of the audit tree with the security tree Paul Moore <paul@paul-moore.com> - 2016-06-24 17:10 +0200
    Re: linux-next: manual merge of the audit tree with the security tree Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-06-24 17:30 +0200
      Re: linux-next: manual merge of the audit tree with the security tree Paul Moore <paul@paul-moore.com> - 2016-06-24 18:30 +0200
        Re: linux-next: manual merge of the audit tree with the security tree Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-06-25 09:30 +0200

csiph-web