Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1431073
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One |
| Date | Sat, 25 Jun 2016 09:20:02 +0200 |
| Message-ID | <rNQ2J-2va-9@gated-at.bofh.it> (permalink) |
| References | <rNMLw-lT-3@gated-at.bofh.it> <rNMLw-lT-5@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zaRBsRFn0XYhEU69" |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 77 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | dev@linux-sunxi.org, linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Chen-Yu Tsai <wens@csie.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> |
| X-Original-Date | Sat, 25 Jun 2016 09:18:09 +0200 |
| X-Original-Message-ID | <20160625071808.GE4000@lukather> |
| X-Original-References | <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-14-megous@megous.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1431073 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Sat, Jun 25, 2016 at 05:45:10AM +0200, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Xulong Orange Pi One uses GPIO based regulator that
> switches between two voltages: 1.1V and 1.3V. The
> regulator is controlled from the PL6 pin.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> v2
> - add missing pinctrl-names for gpio-regulator
> ---
> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> index 0adf932..b1bd6b0 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> @@ -88,6 +88,25 @@
> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
> };
> };
> +
> + vdd_soc: gpio-regulator {
> + compatible = "regulator-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&vdd_reg_r_opc>;
> +
> + regulator-name = "soc-vdd-supply";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-boot-on;
> + regulator-type = "voltage";
It should be marked as always-on.
Otherwise, if the cpufreq driver is not enabled, the regulator will be
shutdown, which is not that great :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One megous@megous.com - 2016-06-25 05:50 +0200 Re: [PATCH v2 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-25 09:20 +0200
csiph-web