Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431040

Re: [PATCH 1/2] perf data convert: Include config.h header

Show all headers | View raw

You can add:

Fixes: 41840d211c51 ("perf config: Move config declarations from 
util/cache.h to util/config.h")

Thank you.

On 2016/6/24 20:40, Jiri Olsa wrote:
> otherwise some compiler might scream:
>
>    $ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
>      BUILD:   Doing 'make -j4' parallel build
>      CC       util/data-convert-bt.o
>    util/data-convert-bt.c: In function ‘convert__config’:
>    util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
>       c->queue_size = perf_config_u64(var, value);
>    ...
>
> Link: http://lkml.kernel.org/n/tip-t9dyx71w49dy5tacpdzr5b2p@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>   tools/perf/util/data-convert-bt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 9f53020c3269..5186bb1168af 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -26,6 +26,7 @@
>   #include "evlist.h"
>   #include "evsel.h"
>   #include "machine.h"
> +#include "config.h"
>   
>   #define pr_N(n, fmt, ...) \
>   	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf data convert: Include config.h header Jiri Olsa <jolsa@kernel.org> - 2016-06-24 14:50 +0200
  [PATCH 2/2] perf tools: Use proper dso name for is_regular_file Jiri Olsa <jolsa@kernel.org> - 2016-06-24 14:50 +0200
    [tip:perf/core] perf symbols: Use proper dso name for  is_regular_file tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-06-29 11:50 +0200
  Re: [PATCH 1/2] perf data convert: Include config.h header "Wangnan (F)" <wangnan0@huawei.com> - 2016-06-25 03:30 +0200
    Re: [PATCH 1/2] perf data convert: Include config.h header Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-26 19:10 +0200
  [tip:perf/core] perf data convert: Include config.h header tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-06-29 11:50 +0200

csiph-web