Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431030

Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 24.6.2016 05:09, Chen-Yu Tsai wrote:
>> +static int sun8i_ths_h3_init(struct platform_device *pdev,
>> +                            struct sun8i_ths_data *data)
>> +{
>> +       int ret;
>> +       size_t callen;
>> +       s32 *caldata;
>> +
>> +       data->busclk = devm_clk_get(&pdev->dev, "ahb");
>> +       if (IS_ERR(data->busclk)) {
>> +               ret = PTR_ERR(data->busclk);
>> +               dev_err(&pdev->dev, "failed to get ahb clk: %d\n", ret);
>> +               return ret;
>> +       }
>> +
>> +       data->clk = devm_clk_get(&pdev->dev, "ths");
>> +       if (IS_ERR(data->clk)) {
>> +               ret = PTR_ERR(data->clk);
>> +               dev_err(&pdev->dev, "failed to get ths clk: %d\n", ret);
>> +               return ret;
>> +       }
>> +
>> +       data->reset = devm_reset_control_get(&pdev->dev, "ahb");
> 
> IIRC with the new shared reset control stuff merged, you are supposed
> to specify whether you want a shared or exclusive one when you ask for
> it.

Here devm_reset_control_get will get the exclusive reference. So this
should be ok.

regards,
  Ondrej

> 
> Regards
> ChenYu
> 
>> +MODULE_LICENSE("GPL v2");
>> --
>> 2.9.0
>>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 megous@megous.com - 2016-06-23 21:30 +0200
  Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 Chen-Yu Tsai <wens@csie.org> - 2016-06-24 05:10 +0200
    Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 Ondřej Jirman <megous@megous.com> - 2016-06-25 00:00 +0200
    Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 Ondřej Jirman <megous@megous.com> - 2016-06-25 02:40 +0200
      Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 Chen-Yu Tsai <wens@csie.org> - 2016-06-25 03:00 +0200
        Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 Ondřej Jirman <megous@megous.com> - 2016-06-25 03:00 +0200

csiph-web