Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1430923
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations |
| Date | 2016-06-24 22:30 +0200 |
| Message-ID | <rNFTH-4ti-1@gated-at.bofh.it> (permalink) |
| References | <rMj8R-7Dk-3@gated-at.bofh.it> <rMEZI-54t-5@gated-at.bofh.it> <rMEZI-54t-13@gated-at.bofh.it> <rNE1z-3iA-27@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, Jun 24, 2016 at 12:27:27PM -0600, Jason Gunthorpe wrote:
> On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote:
>
> > if (chip->ops->req_canceled(chip, status)) {
> > dev_err(chip->pdev, "Operation Canceled\n");
> > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n",
> > + ordinal, jiffies_to_msecs(jiffies -
> > start));
>
> [..]
>
> > chip->ops->cancel(chip);
> > dev_err(chip->pdev, "Operation Timed out\n");
> > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal,
> > + jiffies_to_msecs(jiffies - start));
>
> No sense in logging twice, just enhance the existingerror message.
Absolutely agree. Jason, thanks for pointing this out!
/Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-06-24 20:30 +0200 Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-24 22:30 +0200
csiph-web