Re: [PATCH] mm: prevent KASAN false positives in kmemleak

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: prevent KASAN false positives in kmemleak
Date	2016-06-23 12:10 +0200
Message-ID	<rN9Ka-8oP-7@gated-at.bofh.it> (permalink)
References	<rMUrL-6vZ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 22, 2016 at 07:47:11PM +0200, Dmitry Vyukov wrote:
> When kmemleak dumps contents of leaked objects it reads whole
> objects regardless of user-requested size. This upsets KASAN.
> Disable KASAN checks around object dump.
> 
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> ---
>  mm/kmemleak.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index e642992..04320d3 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -307,8 +307,10 @@ static void hex_dump_object(struct seq_file *seq,
>  	len = min_t(size_t, object->size, HEX_MAX_LINES * HEX_ROW_SIZE);
>  
>  	seq_printf(seq, "  hex dump (first %zu bytes):\n", len);
> +	kasan_disable_current();
>  	seq_hex_dump(seq, "    ", DUMP_PREFIX_NONE, HEX_ROW_SIZE,
>  		     HEX_GROUP_SIZE, ptr, len, HEX_ASCII);
> +	kasan_enable_current();
>  }

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: prevent KASAN false positives in kmemleak Dmitry Vyukov <dvyukov@google.com> - 2016-06-22 19:50 +0200
  Re: [PATCH] mm: prevent KASAN false positives in kmemleak Catalin Marinas <catalin.marinas@arm.com> - 2016-06-23 12:10 +0200

csiph-web