Re: [PATCH v4 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system
Date	2016-06-23 10:50 +0200
Message-ID	<rN8uK-7ox-23@gated-at.bofh.it> (permalink)
References	<rMmgq-1sA-7@gated-at.bofh.it> <rMmgq-1sA-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 21, 2016 at 7:10 AM, Tan Jui Nee <jui.nee.tan@intel.com> wrote:

> This driver uses the P2SB hide/unhide mechanism cooperatively
> to pass the PCI BAR address to the gpio platform driver.
>
> Signed-off-by: Tan Jui Nee <jui.nee.tan@intel.com>
> ---
> Changes in V4:
>         - Move Kconfig option CONFIG_X86_INTEL_NON_ACPI from
>           [PATCH 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's
>           to
>           [PATCH 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system
>           since the config is used in latter patch.
>         - Select CONFIG_P2SB when CONFIG_LPC_ICH is enabled.
>         - Remove #ifdef CONFIG_X86_INTEL_NON_ACPI and use
>           #if defined(CONFIG_X86_INTEL_NON_ACPI) when lpc_ich_misc is called
>           as suggested by Lee Jones.
>         - Use single dimensional array instead of 2D array for apl_gpio_io_res
>           structure and use DEFINE_RES_IRQ for its IRQ resource.

I guess this patch will also change, also fix the screamings from
the build robot please.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] pinctrl/broxton: enable platform device in the absent of ACPI enumeration Tan Jui Nee <jui.nee.tan@intel.com> - 2016-06-21 07:20 +0200
  [PATCH v4 1/3] pinctrl/broxton: enable platform device in the absent of ACPI enumeration Tan Jui Nee <jui.nee.tan@intel.com> - 2016-06-21 07:20 +0200
    Re: [PATCH v4 1/3] pinctrl/broxton: enable platform device in the  absent of ACPI enumeration Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 10:50 +0200
  [PATCH v4 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's Tan Jui Nee <jui.nee.tan@intel.com> - 2016-06-21 07:20 +0200
    Re: [PATCH v4 2/3] x86/platform/p2sb: New Primary to Sideband bridge  support driver for Intel SOC's Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 10:50 +0200
  [PATCH v4 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system Tan Jui Nee <jui.nee.tan@intel.com> - 2016-06-21 07:20 +0200
    Re: [PATCH v4 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake  GPIO pinctrl in non-ACPI system kbuild test robot <lkp@intel.com> - 2016-06-21 08:10 +0200
    Re: [PATCH v4 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake  GPIO pinctrl in non-ACPI system Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 10:50 +0200

csiph-web