Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429527

Re: [PATCH 2/5] gpio: of: drop needless gpio_chip look-up in of_parse_own_gpio()

Show all headers | View raw

On Tue, Jun 14, 2016 at 12:07 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This function is doing more complicated than needed.  The caller of
> this function, of_gpiochip_scan_gpios() already knows the pointer to
> the gpio_chip.  It can pass it to of_parse_own_gpio() instead of
> looking up the gpio_chip by gpiochip_find().
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied!

First I was worried about this semantic change:

> -       chip_np = np->parent;
> +       chip_np = chip->of_node;

But then I read up on the code and saw that of_gpiochip_add() sets
it to the parent if not set before.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] gpio: refactor of_parse_own_gpio() and of_get_named_gpiod_flags() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-14 12:10 +0200
  [PATCH 2/5] gpio: of: drop needless gpio_chip look-up in of_parse_own_gpio() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-14 12:10 +0200
    Re: [PATCH 2/5] gpio: of: drop needless gpio_chip look-up in of_parse_own_gpio() Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 09:40 +0200
  [PATCH 4/5] gpio: of: remove of_gpiochip_and_xlate() and struct gg_data Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-14 12:10 +0200
    Re: [PATCH 4/5] gpio: of: remove of_gpiochip_and_xlate() and struct gg_data Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 09:50 +0200
  Re: [PATCH 0/5] gpio: refactor of_parse_own_gpio() and of_get_named_gpiod_flags() Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 09:50 +0200

csiph-web