Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1429545
| From | Stephen Boyd <stephen.boyd@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] extcon: Check for incorrect connection type in notifier register |
| Date | 2016-06-23 10:00 +0200 |
| Message-ID | <rN7Il-6Qs-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
If we call extcon_register_notifier() with the wrong cable type, it blows up with an oops instead of returning an error code. Let's be nice and fail gracefully given that the consumer might not know if the cable is supported by the extcon provider. Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> --- drivers/extcon/extcon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 21a123cadf78..161acb826334 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -586,6 +586,8 @@ int extcon_register_notifier(struct extcon_dev *edev, unsigned int id, return -EINVAL; idx = find_cable_index_by_id(edev, id); + if (idx < 0) + return idx; spin_lock_irqsave(&edev->lock, flags); ret = raw_notifier_chain_register(&edev->nh[idx], nb); @@ -611,6 +613,8 @@ int extcon_unregister_notifier(struct extcon_dev *edev, unsigned int id, return -EINVAL; idx = find_cable_index_by_id(edev, id); + if (idx < 0) + return idx; spin_lock_irqsave(&edev->lock, flags); ret = raw_notifier_chain_unregister(&edev->nh[idx], nb); -- 2.9.0.rc2.8.ga28705d
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] extcon: Check for incorrect connection type in notifier register Stephen Boyd <stephen.boyd@linaro.org> - 2016-06-23 10:00 +0200 Re: [PATCH] extcon: Check for incorrect connection type in notifier register Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-23 12:50 +0200
csiph-web