Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1429443
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] dlm: Use kmemdup instead of kmalloc and memcpy |
| Date | 2016-06-23 07:00 +0200 |
| Message-ID | <rN4U9-50i-15@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. The Coccinelle semantic patch used to make this change is as follows: @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 1ab012a..963016c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1279,10 +1279,9 @@ static void init_local(void) if (dlm_our_addr(&sas, i)) break; - addr = kmalloc(sizeof(*addr), GFP_NOFS); + addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS); if (!addr) break; - memcpy(addr, &sas, sizeof(*addr)); dlm_local_addr[dlm_local_count++] = addr; } } -- 1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] dlm: Use kmemdup instead of kmalloc and memcpy Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-06-23 07:00 +0200
csiph-web