Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices

From	"Kani, Toshimitsu" <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices
Date	2016-06-21 19:20 +0200
Message-ID	<rMxvb-ii-7@gated-at.bofh.it> (permalink)
References	(9 earlier) <rMudX-6uM-3@gated-at.bofh.it> <rMwfM-7MM-31@gated-at.bofh.it> <rMwIN-8bK-1@gated-at.bofh.it> <rMx29-8iu-9@gated-at.bofh.it> <rMx29-8iu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-06-21 at 09:45 -0700, Dan Williams wrote:
> On Tue, Jun 21, 2016 at 9:35 AM, Kani, Toshimitsu <toshi.kani@hpe.com>
> wrote:
> > On Tue, 2016-06-21 at 09:25 -0700, Dan Williams wrote:
> > > On Tue, Jun 21, 2016 at 8:44 AM, Kani, Toshimitsu <toshi.kani@hpe.com>
> > > wrote:
> > > > 
 :
> > > > I think GENHD_FL_DAX is more appropriate since DAX does not use a
> > > > request queue, except for protecting the underlining device being
> > > > disabled while direct_access() is called (b2e0d1625e19).
> > > > 
> > > > About protecting direct_access, this patch assumes that the
> > > > underlining device cannot be disabled until dtr() is called.  Is this
> > > > correct?  If not, I will need to call dax_map_atomic().
> > >
> > > Kernel internal usages of dax should be using dax_map_atomic() to
> > > safely resolve device removal races.
> >
> > Will do.  In such case, shall I move dax_[un]map_atomic() to block_dev.c
> > and rename them to bdev_dax_[un]map_atomic()?
>
> Sounds good to me.  I know Jeff and Christoph don't like the current
> calling convention of passing in a structure.  Just note that they
> might ask you to change it back to a list of parameters if it moves to
> bdev_dax_map_atomic().

OK, I will change it back to a list of parameters as well.

Thanks,
-Toshi

Thread

[PATCH 0/6] Support DAX for device-mapper dm-linear devices Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 1/6] genhd: Add GENHD_FL_DAX to gendisk flags Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 4/6] dm-linear: Add linear_direct_access() Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 6/6] dm: Enable DAX support for mapper device Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 3/6] dm: Add dm_blk_direct_access() for mapped device Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 2/6] block: Check GENHD_FL_DAX for DAX capability Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  [PATCH 5/6] dm, dm-linear: Add dax_supported to dm_target Toshi Kani <toshi.kani@hpe.com> - 2016-06-14 00:40 +0200
  Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-14 01:00 +0200
    Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-20 20:30 +0200
      Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-20 21:50 +0200
        Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-20 23:50 +0200
          Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 00:10 +0200
            Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-21 00:40 +0200
              Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-21 15:50 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 18:00 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 18:10 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-21 18:30 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-21 18:50 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 19:20 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 19:00 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-21 20:30 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-22 19:50 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-22 21:20 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-22 22:20 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-23 00:40 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-23 01:20 +0200
          Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-21 00:50 +0200
      Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-20 23:10 +0200
  Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-14 01:20 +0200
    Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-14 02:00 +0200
      Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-14 02:10 +0200
        Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-14 09:40 +0200
      Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Jeff Moyer <jmoyer@redhat.com> - 2016-06-14 16:00 +0200
        Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-14 17:50 +0200
          Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-14 20:10 +0200
          Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Jeff Moyer <jmoyer@redhat.com> - 2016-06-14 22:20 +0200
            Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-15 03:50 +0200
              Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Dan Williams <dan.j.williams@intel.com> - 2016-06-15 04:10 +0200
                Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer <snitzer@redhat.com> - 2016-06-15 04:40 +0200
        Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-06-14 18:00 +0200

csiph-web