Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427977

Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime

From Stephan Mueller <smueller@chronox.de>
Newsgroups linux.kernel
Subject Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime
Date 2016-06-21 19:20 +0200
Message-ID <rMxvb-ii-1@gated-at.bofh.it> (permalink)
References <rL4lA-8sx-33@gated-at.bofh.it> <rMxbQ-8nf-3@gated-at.bofh.it> <rMxvb-ii-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, 21. Juni 2016, 10:12:24 schrieb John Stultz:

Hi John,
> 
> So this is definitely more clear then what was described earlier, and
> worries me because on many x86 machines (though fewer I guess these
> days then in the past) the clocksource will often not be the TSC (and
> have lower resolution).

Please note, the use of the ktime_get_raw_ns() is *only* used as a fallback on 
architectures where random_get_entropy / get_cycles is not implemented.

So, on X86 and on many other arches, this function call will never be 
triggered.

...
> 
> But please just make sure the reason why you're using that specific
> interface is clearly documented in the code so we don't have to later
> reverse engineer the intent.

Will do.

@Arnd: I would prepare a patch then using ktime_get_raw_ns and providing a 
good documentation in the code.

Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: use timespec64 for jent_get_nstime Arnd Bergmann <arnd@arndb.de> - 2016-06-17 18:00 +0200
  Re: [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-18 10:20 +0200
  Re: [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 08:50 +0200
    Re: [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 10:40 +0200
    Re: [PATCH] crypto: use timespec64 for jent_get_nstime Arnd Bergmann <arnd@arndb.de> - 2016-06-21 10:40 +0200
      Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime John Stultz <john.stultz@linaro.org> - 2016-06-21 18:30 +0200
        Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 18:40 +0200
          Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime John Stultz <john.stultz@linaro.org> - 2016-06-21 18:50 +0200
            Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 19:00 +0200
              Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 19:20 +0200
              Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime John Stultz <john.stultz@linaro.org> - 2016-06-21 19:20 +0200
              Re: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime Stephan Mueller <smueller@chronox.de> - 2016-06-21 19:40 +0200

csiph-web