Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend

From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date	2016-06-21 18:00 +0200
Message-ID	<rMwfL-7MM-3@gated-at.bofh.it> (permalink)
References	<rMvWr-7DO-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 21 Jun 2016, Nicolas Ferre wrote:

> Le 21/06/2016 03:32, Wenyou Yang a �crit :
> > In order to save power consumption, as a workaround, forcibly suspend
> > the USB PORTA/B/C via setting the SUSPEND_A/B/C bits of OHCI Interrupt
> > Configuration Register in the SFR while OHCI USB suspend.
> > 
> > This suspend operation must be done before the USB clock is disabled,
> > resume after the USB clock is enabled.
> > 
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> Alan, can you take it as it doesn't have dependency on the at91 material
> anymore.

Sorry, I will not accept this patch until Wenyou Yang answers the 
questions I raised in

	http://marc.info/?l=linux-usb&m=146307669102601&w=2

and

	http://marc.info/?l=linux-usb&m=146541324027407&w=2

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-21 03:50 +0200
  Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 17:40 +0200
  Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB  suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-21 17:40 +0200
    Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alan Stern <stern@rowland.harvard.edu> - 2016-06-21 18:00 +0200

csiph-web