Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat)
Date	2016-06-21 17:50 +0200
Message-ID	<rMw66-7Hw-15@gated-at.bofh.it> (permalink)
References	<rM8Q9-16s-7@gated-at.bofh.it> <rMrg7-4Cx-63@gated-at.bofh.it> <rMsvw-5kN-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, June 21, 2016 1:34:59 PM CEST Andreas Schwab wrote:
> "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
> 
> >> @@ -78,9 +79,9 @@
> >>
> >>   #ifdef CONFIG_COMPAT
> >>   #define TASK_SIZE_32               UL(0x100000000)
> >> -#define TASK_SIZE           (test_thread_flag(TIF_32BIT) ? \
> >> +#define TASK_SIZE           (is_compat_task() ?             \
> >>                              TASK_SIZE_32 : TASK_SIZE_64)
> >> -#define TASK_SIZE_OF(tsk)   (test_tsk_thread_flag(tsk, TIF_32BIT) ? \
> >> +#define TASK_SIZE_OF(tsk)   (is_compat_thread(tsk) ? \
> > It should be
> > +#define TASK_SIZE_OF(tsk)      (is_compat_thread(task_thread_info(tsk)) ? \
> > is_compat_thread takes "struct thread_info *thread" while TASK_SIZE_OF takes
> > "struct task_struct *tsk"tsk.
> 
> If that doesn't throw an error does that mean that TASK_SIZE_OF is
> unused?

I think that is correct. On some architectures, TASK_SIZE (which is used)
is defined as TASK_SIZE_OF(current), but the definition above doesn't
do that and there are no other users.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for  AArch32 compat) "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-06-21 12:40 +0200
  Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Andreas Schwab <schwab@suse.de> - 2016-06-21 14:00 +0200
    Re: [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Arnd Bergmann <arnd@arndb.de> - 2016-06-21 17:50 +0200

csiph-web