Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support
Date	2016-06-21 17:20 +0200
Message-ID	<rMvD3-7x7-5@gated-at.bofh.it> (permalink)
References	<rMunE-6zQ-29@gated-at.bofh.it> <rMunE-6zQ-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21/06/2016 15:50, Joerg Roedel wrote:
> The code has a few style issues (thing I'd implemented differently), but
> it looks functional. Anyway, before merging this the last 3 patches need
> to be acked by the KVM maintainers.
> 
> Paolo?

I think patches 9 and 10 should be squashed because the code after patch
9 is only partly functional.

Likewise, I think this:

+
+	if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir))
+		amd_iommu_irq_ops.capability |= (1 << IRQ_POSTING_CAP);

from patch 1 should be moved to patch 6.

Otherwise the KVM bits are sane.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Joerg Roedel <joro@8bytes.org> - 2016-06-21 16:00 +0200
  Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Joerg Roedel <joro@8bytes.org> - 2016-06-21 16:50 +0200
  Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support Paolo Bonzini <pbonzini@redhat.com> - 2016-06-21 17:20 +0200

csiph-web