Re: [PATCH] crypto : async implementation for sha1-mb

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto : async implementation for sha1-mb
Date	2016-06-21 15:10 +0200
Message-ID	<rMtBf-6h7-5@gated-at.bofh.it> (permalink)
References	<rMdZv-4vT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 20, 2016 at 01:25:46PM -0700, Megha Dey wrote:
>
> -	desc->tfm = child;
> -	desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP;  /* check this again */
> +	ahash_request_set_tfm(desc, child);
> +	ahash_request_set_callback(desc, CRYPTO_TFM_REQ_MAY_SLEEP, NULL, NULL);

The callback function needs to be set, or this will crash when
it returns -EINPROGRESS.

>  	if (err) {
>  		req->base.complete = rctx->complete;

This is not calling the completion function conditinoally, rather
it is trying to restore the original completion function when we
are done.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] crypto : async implementation for sha1-mb Megha Dey <megha.dey@intel.com> - 2016-06-20 22:30 +0200
  Re: [PATCH] crypto : async implementation for sha1-mb Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-21 15:10 +0200

csiph-web