Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device
Date	2016-06-21 14:10 +0200
Message-ID	<rMsFb-5Dv-3@gated-at.bofh.it> (permalink)
References	<rMr6q-4wM-19@gated-at.bofh.it> <rMr6q-4wM-21@gated-at.bofh.it> <rMrSN-579-9@gated-at.bofh.it> <rMslQ-5hj-29@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Jun 21, 2016 at 01:42:16PM +0200, Rafael J. Wysocki wrote:
> > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > +					const char *name)
> > > +{
> > > +	return is_acpi_data_node(fwnode) ?
> > > +		(!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > +}
> > 
> > Looks fine to me.
> > 
> > One question - is it expected that matching ACPI data nodes is always
> > case insensitive?
> 
> That would not be a correct expectation in theory, although I don't think it
> really matters in practice.

OK.

Maybe it is good idea to document that in acpi_data_node_match(). A
comment explaining why we use strcasecmp() for now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESEND PATCH v3 1/2] device property: Add function to search  for named child of device Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-21 13:20 +0200
  Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-21 13:50 +0200
    RE: [RESEND PATCH v3 1/2] device property: Add function to search  for named child of device "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-06-21 14:00 +0200
      Re: [RESEND PATCH v3 1/2] device property: Add function to search  for named child of device Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-21 14:10 +0200
      Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-21 17:10 +0200
    Re: [RESEND PATCH v3 1/2] device property: Add function to search  for named child of device Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-21 14:10 +0200

csiph-web