Re: [PATCH 0/3] Fixes on remote unwind

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] Fixes on remote unwind
Date	2016-06-21 09:40 +0200
Message-ID	<rMorU-2Ll-15@gated-at.bofh.it> (permalink)
References	<rHIKC-7iL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 08, 2016 at 10:15:35AM +0000, He Kuang wrote:
> The remote unwind can supported scenario where we collect on a x86_64
> machine and want to do analysis on a ARM64 or x86-32 machine. Though
> this is not tested, after Arnaldo questioned the above issue, I tested
> and found a bug.
> 
> In util/unwind-libunwind-local.c, PERF_REG_SP/IP is used, but those
> macros are assigned to the host platform, we should redefine them in
> the wrapper file, for example in "util/libunwind/x86_32.c".
> 
> After fixing this problem, i686 perf.data can be parsed on aarch64
> machine.
> 
> To Arnaldo, I noticed that this patch
> "perf tools: Find vdso supporting cross-platform analysis"
> is not on "origin/perf/unwind" branch, this patch was applied, please
> check if it was missed, the above test needs this patch.
> 
> Thank you.
> 
> He Kuang (3):
>   perf unwind: Change macro names of perf register
>   perf unwind: Fix wrongly used regs for x86_32 unwind
>   perf unwind: Fix wrongly used regs for aarch64 unwind

for the patchset:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 0/3] Fixes on remote unwind Jiri Olsa <jolsa@redhat.com> - 2016-06-21 09:40 +0200

csiph-web