Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1427188

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH V2 resend] libata:fix kernel panic when hotplug
Date 2016-06-21 03:50 +0200
Message-ID <rMiZb-7y9-5@gated-at.bofh.it> (permalink)
References <rKxfX-3Ey-1@gated-at.bofh.it> <rKM5j-4rD-17@gated-at.bofh.it> <rMiFP-7rl-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>>>>>> "Tejun" == Tejun Heo <tj@kernel.org> writes:
>
>>> In fact,we don't need libata to deal with hotplug in sas environment.
>>> So we can't run ata hotplug task when ata port is sas host.
>
> Tejun> Martin, can you please confirm whether the above is true.  If so,
> Tejun> I'll route the patch through libata w/ stable cc'd.
>
> Not exactly a libsas expert. James? Dan?

While it is true that libsas itself handles adding / removing devices
we have historically avoided this conflict because
ATA_PFLAG_SCSI_HOTPLUG is never set for libsas ata_ports.  So the bug
/ behavior change is that  ATA_PFLAG_SCSI_HOTPLUG gets set in the
first place.  Ignoring it is a band-aid / not the real fix afaics.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 resend] libata:fix kernel panic when hotplug DingXiang <dingxiang@huawei.com> - 2016-06-16 06:40 +0200
  Re: [PATCH V2 resend] libata:fix kernel panic when hotplug Tejun Heo <tj@kernel.org> - 2016-06-16 22:30 +0200
    Re: [PATCH V2 resend] libata:fix kernel panic when hotplug "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-21 03:30 +0200
      Re: [PATCH V2 resend] libata:fix kernel panic when hotplug Dan Williams <dan.j.williams@intel.com> - 2016-06-21 03:50 +0200
        Re: [PATCH V2 resend] libata:fix kernel panic when hotplug Tejun Heo <tj@kernel.org> - 2016-06-21 17:50 +0200
          Re: [PATCH V2 resend] libata:fix kernel panic when hotplug dingxiang <dingxiang@huawei.com> - 2016-06-22 08:50 +0200

csiph-web