Re: linux-next: build warnings after merge of the pci tree

From	Bjorn Helgaas <bhelgaas@google.com>
Newsgroups	linux.kernel
Subject	Re: linux-next: build warnings after merge of the pci tree
Date	2016-06-21 03:40 +0200
Message-ID	<rMiPv-7uu-5@gated-at.bofh.it> (permalink)
References	<rLWFk-1N6-5@gated-at.bofh.it> <rMcTM-3R8-13@gated-at.bofh.it> <rMimt-7ky-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 20, 2016 at 8:08 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Bjorn,
>
> On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
>> > Hi Bjorn,
>> >
>> > After merging the pci tree, today's linux-next build (arm
>> > multi_v7_defconfig) produced these warnings:
>> >
>> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
>> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return err;
>> >           ^
>> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return PTR_ERR(cfg);
>> >           ^
>> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >   return err;
>> >          ^
>> >
>> > Introduced by commit
>> >
>> >   3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")
>>
>> Fixed, thanks a lot, Stephen!
>
> Thanks.  Unfortunately, I still get this warning:
>
> drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>    return PTR_ERR(cfg);
>           ^

Crap, sorry, PTR_ERR/ERR_PTR confusion.  I *think* I fixed it now.

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build warnings after merge of the pci tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-20 04:00 +0200
  Re: linux-next: build warnings after merge of the pci tree Bjorn Helgaas <helgaas@kernel.org> - 2016-06-20 21:20 +0200
    Re: linux-next: build warnings after merge of the pci tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-21 03:10 +0200
      Re: linux-next: build warnings after merge of the pci tree Bjorn Helgaas <bhelgaas@google.com> - 2016-06-21 03:40 +0200

csiph-web