Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427114
| From | Francois Romieu <romieu@fr.zoreil.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) |
| Date | 2016-06-21 00:50 +0200 |
| Message-ID | <rMgb0-5Oa-7@gated-at.bofh.it> (permalink) |
| References | <rJvT0-3Sn-13@gated-at.bofh.it> <rL9lf-3mT-11@gated-at.bofh.it> <rM9sR-1zy-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Netanel Belgazal <netanel@annapurnalabs.com> :
[...]
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
> > new file mode 100644
> > index 0000000..e49ba43
> > --- /dev/null
> > [...]
> > +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg *intr_reg,
> > + u32 rx_delay_interval,
> > + u32 tx_delay_interval,
> > + bool unmask)
> > +{
> > + intr_reg->intr_control = 0;
> > + intr_reg->intr_control |= rx_delay_interval &
> > + ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> > +
> > + intr_reg->intr_control |=
> > + (tx_delay_interval << ENA_ETH_IO_INTR_REG_TX_INTR_DELAY_SHIFT)
> > + & ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> > ^^ TX ?
> >
> > Extra: you should not return NETDEV_TX_BUSY in the xmit handler while
> > queueing is still enabled. Please drop packet and return NETDEV_TX_OK.
> Ack.
>
> Thanks for your review.
Ack/nack regarding use of ..._RX_INTR_DELAY_MASK with ..._TX_INTR_DELAY_SHIFT ?
--
Ueimor
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Francois Romieu <romieu@fr.zoreil.com> - 2016-06-17 23:20 +0200
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal <netanel@annapurnalabs.com> - 2016-06-20 17:40 +0200
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Francois Romieu <romieu@fr.zoreil.com> - 2016-06-21 00:50 +0200
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal <netanel@annapurnalabs.com> - 2016-06-21 12:10 +0200
csiph-web