Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427029
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v9 10/12] kthread: Allow to cancel kthread work |
| Date | 2016-06-20 22:50 +0200 |
| Message-ID | <rMeiR-4CK-5@gated-at.bofh.it> (permalink) |
| References | <rKDv3-7Hj-3@gated-at.bofh.it> <rKDEK-7Kx-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 16, 2016 at 01:17:29PM +0200, Petr Mladek wrote:
> +/*
> + * Returns true when the work could not be queued at the moment.
> + * It happens when it is already pending in a worker list
> + * or when it is being cancelled.
> + *
> + * This function must be called under work->worker->lock.
Replace the comment with a lockdep assertion?
> + */
> +static inline bool queuing_blocked(const struct kthread_work *work)
> +{
> + return !list_empty(&work->node) || work->canceling;
> +}
Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v9 00/12] kthread: Kthread worker API improvements Petr Mladek <pmladek@suse.com> - 2016-06-16 13:20 +0200
[PATCH v9 10/12] kthread: Allow to cancel kthread work Petr Mladek <pmladek@suse.com> - 2016-06-16 13:30 +0200
Re: [PATCH v9 10/12] kthread: Allow to cancel kthread work Tejun Heo <tj@kernel.org> - 2016-06-20 22:50 +0200
[PATCH v9 12/12] kthread: Better support freezable kthread workers Petr Mladek <pmladek@suse.com> - 2016-06-16 13:30 +0200
Re: [PATCH v9 12/12] kthread: Better support freezable kthread workers Tejun Heo <tj@kernel.org> - 2016-06-20 22:40 +0200
csiph-web