Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427012
| From | Helen Koike <helen.koike@collabora.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support |
| Date | 2016-06-20 22:20 +0200 |
| Message-ID | <rMdPQ-4rx-31@gated-at.bofh.it> (permalink) |
| References | <rLlZ7-2TL-5@gated-at.bofh.it> <rMb1E-2DX-49@gated-at.bofh.it> <rMbbk-2Hq-3@gated-at.bofh.it> <rMdmO-41g-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 20-06-2016 16:44, Lars-Peter Clausen wrote:
>> + /* before widget power up */
>> + if (SND_SOC_DAPM_EVENT_ON(event)) {
>> + /* Turn on the chip */
>> + tpa6130a2_power(data, true);
>> + /* Sync the registers */
>> + ret = regcache_sync(data->regmap);
>> + if (ret < 0) {
>> + dev_err(c->dev, "Failed to initialize chip\n");
>> + tpa6130a2_power(data, false);
>> + return ret;
>> + }
>> + /* after widget power down */
>> + } else
>> + tpa6130a2_power(data, false);
>
> checkpatch.pl should complain about this. Kernel code style is if one branch
> has branches the other has to have it as well.
>
Weird, checkpatch.pl doesn't complain. I'll add the braces in v3, thank
you for reviewing
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances Helen Koike <helen.koike@collabora.co.uk> - 2016-06-18 05:40 +0200
[PATCH 3/4] ASoC: tpa6130a2: Use snd soc volsw functions Helen Koike <helen.koike@collabora.co.uk> - 2016-06-18 05:40 +0200
Re: [PATCH 3/4] ASoC: tpa6130a2: Use snd soc volsw functions Sebastian Reichel <sre@kernel.org> - 2016-06-19 00:40 +0200
Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances Sebastian Reichel <sre@kernel.org> - 2016-06-18 12:50 +0200
Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances Sebastian Reichel <sre@kernel.org> - 2016-06-18 23:40 +0200
[PATCH v2 5/5] ASoC: tpa6130a2: Remove goto err_gpio Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:20 +0200
Re: [PATCH v2 5/5] ASoC: tpa6130a2: Remove goto err_gpio Sebastian Reichel <sre@kernel.org> - 2016-06-21 03:50 +0200
[PATCH v2 3/5] ASoC: tpa6130a2: Use snd soc volsw functions Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:30 +0200
Re: [PATCH v2 3/5] ASoC: tpa6130a2: Use snd soc volsw functions Sebastian Reichel <sre@kernel.org> - 2016-06-21 03:50 +0200
Applied "ASoC: tpa6130a2: Use snd soc volsw functions" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-23 16:40 +0200
[PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:30 +0200
Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 21:10 +0200
Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Sebastian Reichel <sre@kernel.org> - 2016-06-21 03:50 +0200
Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Lars-Peter Clausen <lars@metafoo.de> - 2016-06-20 21:50 +0200
Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 22:20 +0200
[PATCH v2 1/5] ASoC: tpa6130a2: Register component Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:30 +0200
Applied "ASoC: tpa6130a2: Register component" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-23 16:40 +0200
[PATCH v2 0/5] ASoC: tpa6130a2: Add support for multiple instances Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:30 +0200
[PATCH v2 2/5] ASoC: tap6130a2: Use regmap Helen Koike <helen.koike@collabora.co.uk> - 2016-06-20 19:30 +0200
Re: [PATCH v2 2/5] ASoC: tap6130a2: Use regmap Sebastian Reichel <sre@kernel.org> - 2016-06-21 03:50 +0200
Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances Sebastian Reichel <sre@kernel.org> - 2016-06-19 22:20 +0200
csiph-web