Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426885

[PATCH v4 net-next v4 04/14] net: dsa: mv88e6xxx: do not increment bus refcount

Show all headers | View raw

The MDIO device probe and remove functions are respectively incrementing
and decrementing the bus refcount themselves. Since these bus level
actions are out of the device scope, remove them.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/dsa/mv88e6xxx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index b3170ea..4b4bffc 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -3712,8 +3712,6 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
 	ps->sw_addr = mdiodev->addr;
 	mutex_init(&ps->smi_mutex);
 
-	get_device(&ps->bus->dev);
-
 	ds->drv = &mv88e6xxx_switch_driver;
 
 	id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID);
@@ -3767,7 +3765,6 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
 	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
 
 	dsa_unregister_switch(ds);
-	put_device(&ps->bus->dev);
 
 	mv88e6xxx_mdio_unregister(ps);
 }
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 net-next v4 00/14] net: dsa: mv88e6xxx: probe compatible Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 02/14] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 11/14] net: dsa: mv88e6xxx: add detection helper Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 09/14] net: dsa: mv88e6xxx: add chip allocation helper Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 06/14] net: dsa: mv88e6xxx: use gpio get optional variant Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
    Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract  switch registers accesses Andrew Lunn <andrew@lunn.ch> - 2016-06-20 18:40 +0200
      Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200
  [PATCH v4 net-next v4 13/14] net: dsa: mv88e6xxx: add port base address to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 12/14] net: dsa: mv88e6xxx: pass compatible info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 18:10 +0200
  [PATCH v4 net-next v4 05/14] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200
  [PATCH v4 net-next v4 01/14] net: dsa: mv88e6xxx: fix style issues Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200
  [PATCH v4 net-next v4 03/14] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200
  [PATCH v4 net-next v4 07/14] net: dsa: mv88e6xxx: remove table args in info lookup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200
  [PATCH v4 net-next v4 04/14] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-20 20:00 +0200

csiph-web