Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429123

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

Show all headers | View raw

On Tue, Jun 21, 2016 at 5:52 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Tue, Jun 21, 2016 at 5:42 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> On Tue, Jun 21, 2016 at 10:43:40AM -0700, Andy Lutomirski wrote:
>>>
>>> Is there a straightforward way that bluetooth and, potentially, other
>>> drivers can just do synchronous crypto in a small buffer specified by
>>> its virtual address?  The actual cryptography part of the crypto code
>>> already works this way, but I can't find an API for it.
>>
>> Yes, single block users should use crypto_cipher_encrypt_one, an
>> example would be drivers/md/dm-crypt.c.
>>
>
> Aha!  I expected something like that to exist, but I couldn't find it.
> I'll change the two offenders I've found so far to use it.
>

Before I do this, can you explain what the difference is between
crypto_cipher and crypto_skcipher?  net/bluetooth/smp.c currently uses
crypto_alloc_skcipher, which you added in:

commit 71af2f6bb22a4bf42663e10f1d8913d4967ed07f
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Sun Jan 24 21:18:30 2016 +0800

    Bluetooth: Use skcipher and hash

Am I just supposed to replace "skcipher" with "cipher" everywhere?

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Andy Lutomirski <luto@kernel.org> - 2016-06-21 19:50 +0200
  Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-22 03:10 +0200
    Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Andy Lutomirski <luto@amacapital.net> - 2016-06-22 04:00 +0200
      Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Andy Lutomirski <luto@amacapital.net> - 2016-06-22 23:50 +0200
        Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Andy Lutomirski <luto@amacapital.net> - 2016-06-23 01:50 +0200
          Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-23 05:50 +0200
            Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-23 08:50 +0200
        Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack  crash, etc) Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-23 05:40 +0200

csiph-web