Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1429103
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() |
| Date | 2016-06-22 22:50 +0200 |
| Message-ID | <rMXfX-8kd-3@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rMva1-75u-1@gated-at.bofh.it> <rMyKC-10p-41@gated-at.bofh.it> <rMLy9-Wz-7@gated-at.bofh.it> <rMVQR-7xn-3@gated-at.bofh.it> <rMXfX-8kd-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 22, 2016 at 10:41:14PM +0200, Boris Brezillon wrote:
> On Wed, 22 Jun 2016 12:16:59 -0700
> Brian Norris <briannorris@chromium.org> wrote:
> > Notably, you're dropping the 'if (!pwm) { }' safety checks that are part
> > of pwm_disable() and pwm_set_polarity(). But I don't think there should
> > be any users relying on that.
>
> Indeed. I can add it back here if you prefer,
Nah, that's ok. I just had to say it anyway :)
> but honestly, PWM users
> that are not checking the value returned by pwm_get() should be
> considered buggy IMHO, and a NULL pointer exception is a good way to
> make people realize they are not properly using the API :).
Seems OK.
Brian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-21 16:50 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Brian Norris <briannorris@chromium.org> - 2016-06-21 20:40 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-21 23:30 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-22 10:20 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Thierry Reding <thierry.reding@gmail.com> - 2016-06-22 14:10 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-22 16:40 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Brian Norris <briannorris@chromium.org> - 2016-06-22 21:20 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Brian Norris <briannorris@chromium.org> - 2016-06-22 22:50 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Thierry Reding <thierry.reding@gmail.com> - 2016-06-23 19:00 +0200
Re: [PATCH v2] pwm: improve args checking in pwm_apply_state() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-22 22:50 +0200
csiph-web