Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429106

Re: [PATCH v3 2/8] coccicheck: make SPFLAGS more useful

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit :
> SPFLAGS is set early, it means that any heuristics done on
> coccicheck cannot be overridden currently. Move SPFLAGS
> after OPTIONS and set this at the end. This lets you override
> any heuristics as coccinelle treats conflicts by only listening
> to the last option that makes sense.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Acked-by: Nicolas Palix <nicolas.palix@imag.fr>
> ---
>  scripts/coccicheck | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index f137b04dfdd3..5319fae910b4 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -30,7 +30,7 @@ else
>  	NPROC="$J"
>  fi
>
> -FLAGS="--very-quiet $SPFLAGS"
> +FLAGS="--very-quiet"
>
>  # spatch only allows include directories with the syntax "-I include"
>  # while gcc also allows "-Iinclude" and "-include include"
> @@ -106,6 +106,9 @@ kill_running() {
>  	done
>  }
>
> +# You can override heuristics with SPFLAGS, these must always go last
> +OPTIONS="$OPTIONS $SPFLAGS"
> +
>  coccinelle () {
>      COCCI="$1"
>
>


-- 
Nicolas Palix
http://lig-membres.imag.fr/palix/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/8] coccicheck: make SPFLAGS more useful "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
  Re: [PATCH v3 2/8] coccicheck: make SPFLAGS more useful "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-22 22:50 +0200

csiph-web