Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1429081
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH v2 1/2] staging: iio: accel: fix error check |
| Date | 2016-06-22 21:50 +0200 |
| Message-ID | <rMWjT-7HS-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
sca3000_read_ctrl_reg() returns a negative number on failure, check for this instead of zero. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> Reviewed-by: Andrew F. Davis <afd@ti.com> Reviewed-by: Jonathan Cameron <jic23@kernel.org> --- drivers/staging/iio/accel/sca3000_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index a8f533a..ec12181 100644 --- a/drivers/staging/iio/accel/sca3000_core.c +++ b/drivers/staging/iio/accel/sca3000_core.c @@ -594,7 +594,7 @@ static ssize_t sca3000_read_frequency(struct device *dev, goto error_ret_mut; ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); mutex_unlock(&st->lock); - if (ret) + if (ret < 0) goto error_ret; val = ret; if (base_freq > 0) -- 2.5.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[RESEND PATCH v2 1/2] staging: iio: accel: fix error check Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-22 21:50 +0200
csiph-web