Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428969
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Al Viro <viro@ZenIV.linux.org.uk> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/8] nfs: don't use ->d_time |
| Date | Wed, 22 Jun 2016 18:50:01 +0200 |
| Message-ID | <rMTvH-5UI-9@gated-at.bofh.it> (permalink) |
| References | <rMRtT-4E1-3@gated-at.bofh.it> <rMRtT-4E1-15@gated-at.bofh.it> |
| X-Original-To | Miklos Szeredi <mszeredi@redhat.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.6.0 (2016-04-01) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 15 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Trond Myklebust <trond.myklebust@primarydata.com> |
| X-Original-Date | Wed, 22 Jun 2016 17:48:06 +0100 |
| X-Original-Message-ID | <20160622164806.GQ14480@ZenIV.linux.org.uk> |
| X-Original-References | <1466606110-24297-1-git-send-email-mszeredi@redhat.com> <1466606110-24297-7-git-send-email-mszeredi@redhat.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1428969 |
Show key headers only | View raw
On Wed, Jun 22, 2016 at 04:35:08PM +0200, Miklos Szeredi wrote:
> static void nfs_d_release(struct dentry *dentry)
> {
> /* free cached devname value, if it survived that far */
> - if (unlikely(dentry->d_fsdata)) {
> + if (unlikely(NFS_D(dentry)->devname)) {
> if (dentry->d_flags & DCACHE_NFSFS_RENAMED)
> WARN_ON(1);
> else
> - kfree(dentry->d_fsdata);
> + kfree(NFS_D(dentry)->devname);
> }
> + kfree(dentry->d_fsdata);
Again, is that safe wrt RCU delays?
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 6/8] nfs: don't use ->d_time Miklos Szeredi <mszeredi@redhat.com> - 2016-06-22 16:40 +0200 Re: [PATCH 6/8] nfs: don't use ->d_time Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-22 18:50 +0200
csiph-web