Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1428697

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands
Date 2016-06-22 13:20 +0200
Message-ID <rMOml-2Gn-19@gated-at.bofh.it> (permalink)
References <rMx29-8iu-19@gated-at.bofh.it> <rMOml-2Gn-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Prasun Maiti <prasunmaiti87@gmail.com> writes:

> For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS,
> HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are
> saved to driver. So, "leX_to_cpu" conversion is required too many
> times afterwards in driver.
>
> This patch reduces the endian: conversion without saving "cpu_to_leX"
> converted values in driver. This will convert endianness in prepare
> command and command response path.
>
> Signed-off-by: Prasun Maiti <prasunmaiti87@gmail.com>

If you send a new version of the patch mark it as [PATCH v2] and always
include a change log so that people don't need to guess what has
changed:

http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

So now you should send a v3 and include a changelog.

-- 
Kalle Valo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-21 16:50 +0200
  Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands kbuild test robot <lkp@intel.com> - 2016-06-21 18:50 +0200
    Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands Kalle Valo <kvalo@codeaurora.org> - 2016-06-22 13:20 +0200
      Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-22 14:20 +0200
      [PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-23 07:30 +0200
    [PATCH] mwifiex: Reduce endian conversion for REG Host Commands Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-22 14:40 +0200

csiph-web