Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428634

Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Jun 17, 2016 at 05:56:02PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
> 
> Add support for the Bananapi M1 Plus A20 development board from
> sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> Bananapro, but differ with the wlan chipset connection and i2s pinout.
> And I also enable the integrated audio codec on default.

This patch content is fine, but there's a lot of small issues:
  - You're not indenting the nodes properly
  - You're missing your Signed-off-by tag
  - And probably other stuff

This has all been reported by checkpatch.

Make sure you run checkpatch, make the modifications needed so that
you don't have any warnings or errors anymore, and resubmit it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly@gmail.com - 2016-06-17 12:00 +0200
  Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus  board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-22 12:10 +0200

csiph-web