Re: [patch V2 00/20] timer: Refactor the timer wheel

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [patch V2 00/20] timer: Refactor the timer wheel
Date	2016-06-22 10:50 +0200
Message-ID	<rMM1b-16D-7@gated-at.bofh.it> (permalink)
References	<rL20p-73O-3@gated-at.bofh.it> <rMKVs-sd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

B1;2802;0cOn Wed, 22 Jun 2016, Mike Galbraith wrote:
> FWIW, testing with ltp, I noticed a new failure in logs.  It turns out
> to be intermittent, but the testcase mostly fails.

You forgot to cc the LTP folks ...
 
> rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
> Test FAILED: sigtimedwait() did not return in the required time
> time_elapsed: 1.197057
> ...come on, you can do it...
> rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
> Test PASSED
> 
> #define ERRORMARGIN 0.1
> ...
>         if ((time_elapsed > SIGTIMEDWAITSEC + ERRORMARGIN)
>             || (time_elapsed < SIGTIMEDWAITSEC - ERRORMARGIN)) {
>                 printf("Test FAILED: sigtimedwait() did not return in "
>                         "the required time\n");
>                 printf("time_elapsed: %lf\n", time_elapsed);
>                 return PTS_FAIL;
>         }
> 
> Looks hohum to me, but gripe did arrive with patch set, so you get a note.

hohum is a euphemism. That's completely bogus.

The only guarantee a syscall with timers has is: timer does not fire early.

Thanks,

	tglx

Thread

[patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:30 +0200
  [patch V2 20/20] timer: Optimization for same expiry time in  mod_timer() Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:30 +0200
  [patch V2 11/20] timer: Give a few structs and members proper names Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:30 +0200
  [patch V2 15/20] timer: Optimize collect timers for NOHZ Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:30 +0200
  [patch V2 19/20] timer: Split out index calculation Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:30 +0200
  [patch V2 06/20] drivers/tty/metag_da: Initialize timer as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 01/20] timer: Make pinned a timer property Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 10/20] hlist: Add hlist_is_singular_node() helper Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 04/20] cpufreq/powernv: Initialize timer as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 08/20] net/ipv4/inet: Initialize timers as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 03/20] x86/mce: Initialize timer as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 17/20] timer: Forward wheel clock whenever possible Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 02/20] x86/apic/uv: Initialize timer as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 14/20] timer: Move __run_timers() function Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 12/20] timer: Switch to a non cascading wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
    Re: [patch V2 12/20] timer: Switch to a non cascading wheel "George Spelvin" <linux@sciencehorizons.net> - 2016-06-18 12:00 +0200
  [patch V2 09/20] timer: Remove mod_timer_pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 13/20] timer: Remove slack leftovers Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  [patch V2 05/20] driver/net/ethernet/tile: Initialize timer as pinned Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
    Re: [patch V2 05/20] driver/net/ethernet/tile: Initialize timer as  pinned Peter Zijlstra <peterz@infradead.org> - 2016-06-21 20:50 +0200
  [patch V2 18/20] timer: Only wake softirq if necessary Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 15:40 +0200
  Re: [patch V2 00/20] timer: Refactor the timer wheel Eric Dumazet <edumazet@google.com> - 2016-06-17 15:50 +0200
    Re: [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 16:00 +0200
      Re: [patch V2 00/20] timer: Refactor the timer wheel Eric Dumazet <edumazet@google.com> - 2016-06-17 16:30 +0200
        Re: [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-20 16:00 +0200
          Re: [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-20 16:50 +0200
            Re: [patch V2 00/20] timer: Refactor the timer wheel Arjan van de Ven <arjanvandeven@gmail.com> - 2016-06-20 18:10 +0200
          Re: [patch V2 00/20] timer: Refactor the timer wheel Arjan van de Ven <arjanvandeven@gmail.com> - 2016-06-20 16:50 +0200
          Re: [patch V2 00/20] timer: Refactor the timer wheel Rik van Riel <riel@redhat.com> - 2016-06-20 21:10 +0200
            Re: [patch V2 00/20] timer: Refactor the timer wheel Eric Dumazet <edumazet@google.com> - 2016-06-21 04:50 +0200
  Re: [patch V2 00/20] timer: Refactor the timer wheel Arjan van de Ven <arjanvandeven@gmail.com> - 2016-06-17 16:30 +0200
  Re: [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-20 17:20 +0200
    Re: [patch V2 00/20] timer: Refactor the timer wheel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-20 17:50 +0200
  Re: [patch V2 00/20] timer: Refactor the timer wheel "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-20 17:40 +0200
  Re: [patch V2 00/20] timer: Refactor the timer wheel Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-22 09:40 +0200
    Re: [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-22 10:50 +0200
      Re: [patch V2 00/20] timer: Refactor the timer wheel Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-22 11:10 +0200
        Re: [patch V2 00/20] timer: Refactor the timer wheel Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-22 15:40 +0200
      Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Cyril Hrubis <chrubis@suse.cz> - 2016-06-22 12:40 +0200
        Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 10:30 +0200
          Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Cyril Hrubis <chrubis@suse.cz> - 2016-06-23 14:00 +0200
            Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel "George Spelvin" <linux@sciencehorizons.net> - 2016-06-23 16:00 +0200
              Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 16:20 +0200
              Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Cyril Hrubis <chrubis@suse.cz> - 2016-06-23 17:20 +0200
                Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 17:30 +0200
                Re: [LTP] [patch V2 00/20] timer: Refactor the timer wheel Cyril Hrubis <chrubis@suse.cz> - 2016-06-23 18:40 +0200

csiph-web