Re: [PATCH 06/12] HID,wacom: Employ atomic_fetch_inc()

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/12] HID,wacom: Employ atomic_fetch_inc()
Date	2016-06-22 10:20 +0200
Message-ID	<rMLy9-Wz-5@gated-at.bofh.it> (permalink)
References	<rMdG9-4no-3@gated-at.bofh.it> <rMdPQ-4rx-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 20 Jun 2016, Davidlohr Bueso wrote:

> Now that we have fetch_inc() we can stop using inc_return() - 1.
> 
> These are very similar to the existing OP-RETURN primitives we already
> have, except they return the value of the atomic variable _before_
> modification.
> 
> Cc: Jiri Kosina <jikos@kernel.org>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

Acked-by: Jiri Kosina <jkosina@suse.cz>

> ---
>  drivers/hid/wacom_sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 499cc8213cfe..88bde7687edd 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1088,7 +1088,7 @@ static int wacom_initialize_battery(struct wacom *wacom)
>  	if (wacom->wacom_wac.features.quirks & WACOM_QUIRK_BATTERY) {
>  		struct power_supply_desc *bat_desc = &wacom->battery_desc;
>  		struct power_supply_desc *ac_desc = &wacom->ac_desc;
> -		n = atomic_inc_return(&battery_no) - 1;
> +		n = atomic_fetch_inc(&battery_no);
>  
>  		bat_desc->properties = wacom_battery_props;
>  		bat_desc->num_properties = ARRAY_SIZE(wacom_battery_props);
> -- 
> 2.6.6
> 

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/12] HID,wacom: Employ atomic_fetch_inc() Davidlohr Bueso <dave@stgolabs.net> - 2016-06-20 22:20 +0200
  Re: [PATCH 06/12] HID,wacom: Employ atomic_fetch_inc() Jiri Kosina <jikos@kernel.org> - 2016-06-22 10:20 +0200

csiph-web